Skip to content

[BS5] Breadcrumbs: active-breadcrumb fix#1414

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-breadcrumbs-2023-02-13
Feb 13, 2023
Merged

[BS5] Breadcrumbs: active-breadcrumb fix#1414
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-breadcrumbs-2023-02-13

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Feb 13, 2023

For ARIA details, see the following link, though the page (as of the time of writing) encodes the active breadcrumb the "old way" (as a link):

Screenshots

Before (this PR):

docsy-bc-before

After, https://deploy-preview-1414--docsydocs.netlify.app/docs/get-started/docsy-as-module/start-from-scratch/:

image

As it was with Bootstrap 4, https://deploy-preview-1356--docsydocs.netlify.app/docs/get-started/docsy-as-module/start-from-scratch/:

image

@chalin chalin mentioned this pull request Feb 13, 2023
50 tasks
@chalin chalin changed the title [BS5] Breadcrumbs active-breadcrumb fix [BS5] Breadcrumbs: active-breadcrumb fix Feb 13, 2023
@chalin chalin merged commit 3eb2cd0 into google:main Feb 13, 2023
@chalin chalin deleted the chalin-im-breadcrumbs-2023-02-13 branch February 13, 2023 22:14
dbreseman added a commit to mendix/docs that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant