[BSv5] replace lighten() by tint-color(), and var/func clean up#1384
[BSv5] replace lighten() by tint-color(), and var/func clean up#1384chalin merged 2 commits intogoogle:mainfrom
Conversation
- Drops $primary-light (breaking change) - Drops `color-diff()` (breaking change) - Replaces custom coloring of Draw.io edit button by outline-primary
|
I think the button change is fine, I can't imagine anyone's look and feel being absolutely wedded to having a red edit button, and the new version will match the surrounding site. Have we checked any of our contributed examples for those elements? |
I've sampled the projects listed under Examples and none use these two SCSS elements. Of course, any project that might happen to use these elements can define their own after this PR is merged -- e.g., by copying the definitions that Docsy gave. The point that we're making here in dropping these elements is to recognize that they aren't a necessary part of Docsy (they weren't even mentioned in the User Guide). |
|
Oops, I had forgotten to commit the removal of |
|
Possible followup: |
$primary-lightcolor-diff()Draw.io edit-button screenshot