Version of Popper isn't compatible with Bootstrap 4, so revert?

[chalin]

In #1245, @geriom wrote:

This implementation requires the latest version of Popper. I ran a grep on the whole website and couldn't find any other Popper instances. So it seems updating the Popper library won't affect anything.

Docsy is still using Bootstrap 4.x, which officially requires Popper ^1.16.1, e.g., see:

https://github.com/twbs/bootstrap/blob/v4.6.2/package.json#L96-L99

  "peerDependencies": {
    "jquery": "1.9.1 - 3",
    "popper.js": "^1.16.1"
  },

I don't know if anything will break, but if the official BS docs require Popper v1, I'd stick with v1 for now --at least for the next release (0.5.0) of Docsy.

Once we upgrade to Bootstrap 5 (#470), we'll be able to upgrade Popper to v2 as well. Thoughts?

[chalin]

In fact, I don't think that we should be fetching and including Popper separately, we should use the Bootstrap bundle, which includes Popper (and more).

[chalin]

I'd suggest that we leave the click-to-copy code and styles in, just unconditionally exclude the code for now. My 2 cents.

[chalin]

Ah, in fact, I confirm that Docsy's tooltips (which use Popper), no longer work. To reproduce:

• Visit https://www.docsy.dev, or the preview of Add click to copy button to code samples #1245, https://deploy-preview-1245--docsydocs.netlify.app.
• Try hovering over one of the footer icons.

What happens? No tooltip appears.

Contrast this with the preview of the last PR (#1189) before #1245 was merged: https://deploy-preview-1189--docsydocs.netlify.app. You should see tooltips now, something like this:

[chalin]

I'm going to revert #1245 now because I'm trying to upgrade Docsy on another project.