-
Notifications
You must be signed in to change notification settings - Fork 735
Upgrade Docsy to version 0.12.0 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For the record, if we ignore the changes to $ (cd public && git diff -bw --ignore-blank-lines) | grep -Ev '_print|\.xml$|\.map$' | grep ^diff | grep -v '^diff --git a/no'
diff --git a/js/main.js b/js/main.js
diff --git a/scss/main.css b/scss/main.css
diff --git a/scss/main.rtl.css b/scss/main.rtl.css |
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Doesn't this PR also need the following?
$ git diff
diff --git a/go.sum b/go.sum
index 3ed3add..8a42dcd 100644
--- a/go.sum
+++ b/go.sum
@@ -1,4 +1,6 @@
+github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3 h1:/iluJkJiyTAdnqrw3Yi9rH2HNHhrrtCmj8VJe7I6o3w=
github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo=
github.com/google/docsy v0.12.0 h1:CddZKL39YyJzawr8GTVaakvcUTCJRAAYdz7W0qfZ2P4=
github.com/google/docsy v0.12.0/go.mod h1:1bioDqA493neyFesaTvQ9reV0V2vYy+xUAnlnz7+miM=
+github.com/twbs/bootstrap v5.3.6+incompatible h1:efmXVyq839m5QQ0+JBUdQQ1TrmoBqvQ5kRhUueKsH+4=
github.com/twbs/bootstrap v5.3.6+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=|
@deining - btw, there is more to be done after this PR gets merged, and before we cut release 0.12.0 of the example. See: |
Added these two lines, as requested. |
|
The heading render hooks was now moved to its correct place according to the new template system. |
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (Haven't double checked if all hard coded Docsy and Hugo versions have been updated, but I'll trust that you were thorough.)
This PR bumps docsy theme to latest released version
v0.12.0.