Skip to content

Conversation

@deining
Copy link
Contributor

@deining deining commented May 27, 2025

This PR bumps docsy theme to latest released version v0.12.0.

@deining deining requested a review from chalin May 27, 2025 16:05
@deining deining changed the title Upgrade Docsy to version 0.11.0 Upgrade Docsy to version 0.12.0 May 27, 2025
@chalin
Copy link
Collaborator

chalin commented May 27, 2025

For the record, if we ignore the changes to no pages (due to updates to i18n/no.html), then only a handfull of generated files change as a result of this PR (or a very close local version I have):

$ (cd public && git diff -bw --ignore-blank-lines) | grep -Ev '_print|\.xml$|\.map$' | grep ^diff | grep -v '^diff --git a/no' 
diff --git a/js/main.js b/js/main.js
diff --git a/scss/main.css b/scss/main.css
diff --git a/scss/main.rtl.css b/scss/main.rtl.css

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Doesn't this PR also need the following?

$ git diff
diff --git a/go.sum b/go.sum
index 3ed3add..8a42dcd 100644
--- a/go.sum
+++ b/go.sum
@@ -1,4 +1,6 @@
+github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3 h1:/iluJkJiyTAdnqrw3Yi9rH2HNHhrrtCmj8VJe7I6o3w=
 github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo=
 github.com/google/docsy v0.12.0 h1:CddZKL39YyJzawr8GTVaakvcUTCJRAAYdz7W0qfZ2P4=
 github.com/google/docsy v0.12.0/go.mod h1:1bioDqA493neyFesaTvQ9reV0V2vYy+xUAnlnz7+miM=
+github.com/twbs/bootstrap v5.3.6+incompatible h1:efmXVyq839m5QQ0+JBUdQQ1TrmoBqvQ5kRhUueKsH+4=
 github.com/twbs/bootstrap v5.3.6+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=

@chalin chalin mentioned this pull request May 27, 2025
3 tasks
@chalin
Copy link
Collaborator

chalin commented May 27, 2025

@deining - btw, there is more to be done after this PR gets merged, and before we cut release 0.12.0 of the example. See:

@deining
Copy link
Contributor Author

deining commented May 27, 2025

Thanks for the updates. Doesn't this PR also need the following?

$ git diff
diff --git a/go.sum b/go.sum
index 3ed3add..8a42dcd 100644
--- a/go.sum
+++ b/go.sum
@@ -1,4 +1,6 @@
+github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3 h1:/iluJkJiyTAdnqrw3Yi9rH2HNHhrrtCmj8VJe7I6o3w=
 github.com/FortAwesome/Font-Awesome v0.0.0-20241216213156-af620534bfc3/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo=
 github.com/google/docsy v0.12.0 h1:CddZKL39YyJzawr8GTVaakvcUTCJRAAYdz7W0qfZ2P4=
 github.com/google/docsy v0.12.0/go.mod h1:1bioDqA493neyFesaTvQ9reV0V2vYy+xUAnlnz7+miM=
+github.com/twbs/bootstrap v5.3.6+incompatible h1:efmXVyq839m5QQ0+JBUdQQ1TrmoBqvQ5kRhUueKsH+4=
 github.com/twbs/bootstrap v5.3.6+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=

Added these two lines, as requested.

@deining
Copy link
Contributor Author

deining commented May 27, 2025

The heading render hooks was now moved to its correct place according to the new template system.

@deining deining requested a review from chalin May 27, 2025 18:49
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Haven't double checked if all hard coded Docsy and Hugo versions have been updated, but I'll trust that you were thorough.)

@chalin chalin merged commit e6f6fdb into google:main May 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants