Conversation
- Add a dive aware archive extractor. - Extract content to temp file if we opened an archive. - Update path lookup logic.
|
i think my biggest concern is that the gfxr and gfxa file could be quite large, compressing them through zip would be really slow? from user perspective that could be a bad experience especially the most common use case is to "save as" the smaller files like .csv files that are from the Replay (for perf counter with different counter set, or maybe remeasure the gpu time), rather than the .gfxr and .gfxa that are from the Capture since they won't be overwritten by Analysis. |
| archive_entry_copy_stat(entry.get(), &st); | ||
|
|
||
| archive_write_header(writer.get(), entry.get()); | ||
| WriteArchiveEntry(writer.get(), infile); |
There was a problem hiding this comment.
should we check the return value?
There was a problem hiding this comment.
Probably, this is still a draft.
Zip has a storage mode which nothing is compressed. Tar does not do compression. Having zip format means I can stop waiting for drive to compress all the file into a zip and extract them later
If you need to csv files, you can just copy the csv file. |
My concern is the consistency of the user experience. If we argue that "Save As" is necessary because manual file copying is a hassle, that logic should apply to the .csv too. Telling users "just open the folder and copy the csv manually if you want that" undermines the purpose of having a "Save" feature in the UI. If a user clicks "Save As" expecting to save their current analysis (the lightweight .csv), but the tool forces them to wait for a 2GB bundle to be written, that creates friction. I am still open to discussions on this, I just want to ensure we don't introduce a new option that ends up confusing users more than it helps. |
Yes, but you probably want "Export" csv instead of "Save As".
Dive can't open a csv file, and I don't think "Open" a csv file makes sense.
That's the argument to have it do exactly one thing - save everything into a bundle - and having csv export being a different menu item. |
2 participants
No description provided.