Skip to content

Move from Ninja to Ninja Multi-Config#679

Merged
angela28chen merged 2 commits intogoogle:mainfrom
angela28chen:ninja-multi
Dec 23, 2025
Merged

Move from Ninja to Ninja Multi-Config#679
angela28chen merged 2 commits intogoogle:mainfrom
angela28chen:ninja-multi

Conversation

@angela28chen
Copy link
Collaborator

@angela28chen angela28chen commented Dec 22, 2025

This is to make the directory structure of the build folder more similar across different platform, since on Windows we use Visual Studio which is Multi-Config.

Announcements:

  • CMAKE_BUILD_TYPE removed and disallowed, do not use this flag anymore
  • Now we require installing host tools under install/ as part of the build process, check out the updated documentation

Changes:

  • Switched generators ("Ninja" -> "Ninja Multi-Config") when using cmake to generate build files for:
    • Host tools (host platforms: Linux/macOS, Windows remains VS generator)
    • Device resources (host platforms: Linux/macOS/Windows)
  • Updated scripts, documentation
  • Updated github workflows
    • Added new step to run cmake install
  • Renamed regression test "Regression_StackOverflow_MacOS" -> "Regression_StackOverflow" because it runs on all host platforms and the name is misleading

@angela28chen angela28chen marked this pull request as ready for review December 22, 2025 23:38
@angela28chen
Copy link
Collaborator Author

Manual Testing (2025/12/22 7:00PM)

  • Windows
    • UI/CLI version verified
  • macOS
    • UI/CLI version verified

Copy link
Collaborator

@wangra-google wangra-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. so much cleaner!

@angela28chen angela28chen merged commit 92e87aa into google:main Dec 23, 2025
14 checks passed
@angela28chen
Copy link
Collaborator Author

Note that the internal release process documentation we have will need to be updated, but I plan to do that at the end of this series of changes.

@angela28chen angela28chen deleted the ninja-multi branch December 23, 2025 19:31
@hysw hysw mentioned this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants