Move from Ninja to Ninja Multi-Config#679
Merged
angela28chen merged 2 commits intogoogle:mainfrom Dec 23, 2025
Merged
Conversation
077b54a to
15e339d
Compare
15e339d to
0396762
Compare
Collaborator
Author
|
Manual Testing (2025/12/22 7:00PM)
|
wangra-google
approved these changes
Dec 23, 2025
Collaborator
wangra-google
left a comment
There was a problem hiding this comment.
Thanks for making this change. so much cleaner!
GrantComm
approved these changes
Dec 23, 2025
Collaborator
Author
|
Note that the internal release process documentation we have will need to be updated, but I plan to do that at the end of this series of changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make the directory structure of the build folder more similar across different platform, since on Windows we use Visual Studio which is Multi-Config.
Announcements:
CMAKE_BUILD_TYPEremoved and disallowed, do not use this flag anymoreinstall/as part of the build process, check out the updated documentationChanges: