Draft
Conversation
hysw
reviewed
Dec 9, 2025
| static void Initialize(const char *argv0) | ||
| { | ||
| QString filename = "dive-" + QDateTime::currentDateTime().toString("yyyyMMdd-HHmmss") + | ||
| QString filename = "dive-crash" + QDateTime::currentDateTime().toString("yyyyMMdd-HHmmss") + |
Collaborator
There was a problem hiding this comment.
Crash handler should output to the logfile, having them separate makes gathering information harder
hysw
reviewed
Dec 9, 2025
| // Write to file using the resolved path | ||
| QFile logFile(m_resolved_path); | ||
|
|
||
| if (logFile.open(QIODevice::WriteOnly | QIODevice::Append)) |
Collaborator
There was a problem hiding this comment.
You probably want a file that is opened for the entire lifetime of the application.
Collaborator
|
Consider using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes application logs to text file. Writing to console is now toggleable.