Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/resolve: parse default registry from version attributes #113

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

cuixq
Copy link
Collaborator

@cuixq cuixq commented Nov 20, 2024

The current implementation assumes Maven Central to be the default registry, however this may not always be true. People can define their own default registry (e.g. in settings.xml).

This PR parses the default registry from version attributes so that a client can specify the default registry.

@cuixq cuixq marked this pull request as draft November 20, 2024 00:26
@cuixq cuixq marked this pull request as ready for review November 27, 2024 03:07
@cuixq cuixq requested a review from PFCM November 27, 2024 03:07
@sarnesjo-google sarnesjo-google merged commit cc569fa into google:main Dec 5, 2024
2 checks passed
@cuixq cuixq deleted the maven branch December 5, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants