Closed
Description
Now, that Dagger runs with JDK 9 (as issue #880 is resolved), it might be time to look forward to JPMS compatibility.
In a first step I'd suggest to add a Automatic-Module-Name
entry to the jar manifest. This way other libraries depending on Dagger can be published to Maven Central or other repositories. Without it, the automatic module name would be derived from the Dagger .jar file and as such is pretty unreliable.
This proposed change doesn't affect any code and will simply make a name reservation until an actual module-info.java
will be added eventually. More info can be found in this blog post.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment