Skip to content

Introduce Non-Prod (iOS & android) toolchain support in Crubit. #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce Non-Prod (iOS & android) toolchain support in Crubit. #1305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 71 additions & 15 deletions common/bazel_support/toolchains/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,36 +8,92 @@

package(default_applicable_licenses = ["//:license"])

# 1. PROD PLATFORMS (Linux)
_PROD_PLATFORMS = {
"linux": [
"@platforms//os:linux",
],
}

# 2. NON-PROD PLATFORMS (Android / iOS)
_NON_PROD_PLATFORMS = {
"ios_aarch64": [
"@platforms//cpu:aarch64",
"@platforms//os:ios",
"//third_party/bazel_rules/apple_support/constraints:device",
],
"ios_aarch64_sim": [
"@platforms//cpu:aarch64",
"@platforms//os:ios",
"//third_party/bazel_rules/apple_support/constraints:simulator",
],
"ios_x86_64": [
"@platforms//cpu:x86_64",
"@platforms//os:ios",
"//third_party/bazel_rules/apple_support/constraints:simulator",
],
"android_x86_64": [
"@platforms//cpu:x86_64",
"@platforms//os:android",
],
"android_arm64_v8a": [
"@platforms//cpu:arm64",
"@platforms//os:android",
],
"android_armv7": [
"@platforms//cpu:armv7",
"@platforms//os:android",
],
"android_x86": [
"@platforms//cpu:x86_32",
"@platforms//os:android",
],
"android_riscv64": [
"@platforms//cpu:riscv64",
"@platforms//os:android",
],
}

# cc_bindings_from_rs
# ====================

[[
# cc_bindings_from_rs
# ===================
toolchain(
name = "cc_bindings_from_rs_on_demand_" + os,
target_compatible_with = ["@platforms//os:" + os],
name = "cc_bindings_from_rs_on_demand_%s" % platform,
target_compatible_with = _PROD_PLATFORMS[platform],
target_settings = [
],
toolchain = "//common/bazel_support:cc_bindings_from_rs_on_demand_impl",
toolchain_type = "//cc_bindings_from_rs/bazel_support:toolchain_type",
),
] for platform in _PROD_PLATFORMS]

# rs_bindings_from_cc
# ===================
[[
toolchain(
name = "cc_bindings_from_rs_on_demand_%s" % platform,
target_compatible_with = _NON_PROD_PLATFORMS[platform],
target_settings = [
],
toolchain = "//common/bazel_support:cc_bindings_from_rs_on_demand_impl",
toolchain_type = "//cc_bindings_from_rs/bazel_support:toolchain_type",
),
] for platform in _NON_PROD_PLATFORMS]

# rs_bindings_from_cc
# ====================
# This direction is currently only available for prod platforms.

[[
toolchain(
name = "rs_bindings_from_cc_on_demand_" + os,
target_compatible_with = ["@platforms//os:" + os],
name = "rs_bindings_from_cc_on_demand_%s" % platform,
target_compatible_with = _PROD_PLATFORMS[platform],
target_settings = [
"//common/bazel_support:use_actual_rs_bindings_from_cc_setting",
],
toolchain = "//common/bazel_support:rs_bindings_from_cc_on_demand_impl",
toolchain_type = "//rs_bindings_from_cc/bazel_support:toolchain_type",
),
] for os in [
# OSes we at least attempt to support.
# Add an OS to this list if Crubit either works, or at least has an
# error message more legible than random internal build issues.
"linux",
"android",
]]
] for platform in _PROD_PLATFORMS]

toolchain(
name = "rs_bindings_from_cc_fake",
Expand Down