Support Unpin trait impls#1299
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Unlike regular trait impls in cc_bindings_from_rs, `Unpin` starts out as `kIsImplemented = true` for all types, and Crubit generates specializations for `kIsImplemented = false` for types that are `!Unpin`. I originally didn't have it negated, but that massively bloated generated APIs and this way felt more intuitive anyways. PiperOrigin-RevId: 940700298
copybara-service
Bot
force-pushed
the
test_940700298
branch
from
1ec99de to
e2d49c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Unpin trait impls
Unlike regular trait impls in cc_bindings_from_rs,
Unpinstarts out askIsImplemented = truefor all types, and Crubit generates specializations forkIsImplemented = falsefor types that are!Unpin. I originally didn't have it negated, but that massively bloated generated APIs and this way felt more intuitive anyways.