CMake cleanup #66
Open
CMake cleanup #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the minimum required version to a value below 3.10 is deprecated in the current version. Hence, set the value to 3.10 in order to avoid deprecation warnings.
Specify the `INCLUDES DESTINATION` in the `install(TARGETS)` command instead of setting a public include directory. The effect is the same. The new approach has the advantage that including `GNUInstallDirs` can be deferred.
Make sure that the include directory is added to the targets that need it, rather than all targets in the current directory.
Make sure that architecture specific compile flags are specified on the source file level rather than at the target level. This removes the need for object libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.