build: Drop endianess workaround #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors a change in leveldb: google/leveldb@201f522, now that compilers can better optimise the generic code.
fanquake
force-pushed
the
patch_for_google
branch
from
de42dcc to
5c6488b
Compare
|
I cannot figure out the endianness of the resulting checksum. |
| std::memcpy(&result, buffer, sizeof(result)); | ||
| return result; | ||
| #endif // BYTE_ORDER_BIG_ENDIAN | ||
| return ((static_cast<uint16_t>(static_cast<uint8_t>(buffer[0]))) | |
There was a problem hiding this comment.
buffer is of type const uint8_t*.
buffer[0] is of type uint8_t.
Hence, the explicit conversion static_cast<uint8_t>(buffer[0]) is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors a change in leveldb: google/leveldb@201f522, now that compilers can better optimise the generic code.