Skip to content

Fix scripts/make_release.sh #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Fix scripts/make_release.sh #395

merged 1 commit into from
May 6, 2025

Conversation

@gchatelet
Copy link
Collaborator

  • Make sure to commit MODULE.bazel
  • Fail before tagging if the repo has unstaged or uncommited changes.

@gchatelet gchatelet requested a review from Mizux May 6, 2025 09:43
@gchatelet
Fix scripts/make_release.sh
b581e45 
- Make sure to commit `MODULE.bazel`
- Fail before tagging if the repo has unstaged or uncommited changes.
Mizux
Mizux approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit b40318d into main May 6, 2025
53 checks passed
@gchatelet gchatelet deleted the update_script branch May 6, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mizux Mizux Mizux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gchatelet @Mizux