cmake: make default test building dependent on being a main project build vs. being included into other projects #290
Conversation
CMakeLists.txt
Outdated
|
|
||
| # Determine if cpu_features is built as a subproject (using add_subdirectory) | ||
| # or if it is the master project. | ||
| if (NOT DEFINED CPU_FEATURES_MAIN_PROJECT) |
There was a problem hiding this comment.
@Mizux, should we add explanation of CPU_FEATURES_MAIN_PROJECT parameter to README?
There was a problem hiding this comment.
I would say no because it is just an internal temp variable result of the test if(CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR), so there is not intention to expose it to the user.
Concerning implementation I prefer the abseil-cpp one
https://github.com/abseil/abseil-cpp/blob/7e8d8018f621e94182876535320718542a4c5f09/CMakeLists.txt#L60-L66
while the option is duplicated it doesn't introduce a new intermediate set() variable...
# when cpu_features is included as subproject (i.e. using add_subdirectory(cpu_features))
# in the source tree of a project that uses it, test rules are disabled.
if(NOT CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR)
option(BUILD_TESTING "Enable test rule" OFF)
else()
option(BUILD_TESTING "Enable test rule" ON)
endif()
There was a problem hiding this comment.
@damageboy do you mind using @Mizux suggestion?
There was a problem hiding this comment.
Sorry, I totally missed this, I will fix according to @Mizux comment
…uild vs. being included into other projects
|
Can this be merged? |
|
Thx @damageboy for the PR (and for the ping!) |
4 participants
Hopefully this is self explanatory.
When using FetchContent with CMake/CPM this will prevent automatically discovering and building tests.
The option to force this is still preserved by proviing
BUILD_TESTINGas an externally settable option