Skip to content

Conversation

@marquitos0119
Copy link
Contributor

This PR adds support for cpu_features on S390X architectures including the latest z16 hwcapabilities.

@google-cla
Copy link

google-cla bot commented Sep 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@borntraeger
Copy link

z15 Model T01 would be 8561 and not 3932
you might also want some older processors as well

2964 and 2965 z13
3906 and 3907 z14

@marquitos0119
Copy link
Contributor Author

Thanks for the review. I ended up removing the explicit model checking, since the elf AT_PLATFORM definition includes this.

Copy link
Collaborator

@gchatelet gchatelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for the PR. A few minor comments before approving.

@marquitos0119
Copy link
Contributor Author

Thanks, I've made those changes

@gchatelet
Copy link
Collaborator

Thanks, I've made those changes

Thx, can you also turn the num_processors field into an int? then I think it's good to go.

@marquitos0119
Copy link
Contributor Author

Made a rookie mistake, forgot to set my git user+email on a new environment and it failed the CLA check. I amended and I think its good to go now

Copy link
Collaborator

@gchatelet gchatelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting a bit for @Mizux to add CI support.

@gchatelet gchatelet merged commit 981fbe3 into google:main Nov 2, 2022
@gchatelet gchatelet added the enhancement New feature or request label Apr 27, 2023
@gchatelet gchatelet added this to the v0.8.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants