-
Notifications
You must be signed in to change notification settings - Fork 288
S390X Support #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S390X Support #274
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
z15 Model T01 would be 8561 and not 3932 2964 and 2965 z13 |
|
Thanks for the review. I ended up removing the explicit model checking, since the elf AT_PLATFORM definition includes this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot for the PR. A few minor comments before approving.
…removed unused include statement
|
Thanks, I've made those changes |
Thx, can you also turn the |
|
Made a rookie mistake, forgot to set my git user+email on a new environment and it failed the CLA check. I amended and I think its good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting a bit for @Mizux to add CI support.
This PR adds support for cpu_features on S390X architectures including the latest z16 hwcapabilities.