Move common logic of AArch64 #268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toor1245
force-pushed
the
aarch64-support-separate-common-os-logic
branch
from
346b4d5 to
030f190
Compare
Mizux
approved these changes
Aug 18, 2022
Mizux
reviewed
Aug 18, 2022
toor1245
force-pushed
the
aarch64-support-separate-common-os-logic
branch
from
030f190 to
392c1c0
Compare
To add support AARCH64 for other operating systems such as macOS(Apple M1), ios, FreeBSD, Windows has been moved common logic from `src/impl_aarch64_linux_or_android.c` to `src/impl_aarch64__base_implementation.inl`, namely: * Definitions for introspection * `Aarch64Info` kEmptyAarch64Info field Removed include "internal/bit_utils.h" from `src/impl_aarch64_linux_or_android.c`, since this include was not used. Also, include `cpuinfo_aarch64` has been removed from linux implementation and replaced with `impl_aarch64__base_implementation.inl`, this include will be used for all other operating systems impl as well Added a compilation check that matches the base X86 implementation Refs: google#121 See also: google#150, google#186, google#204
toor1245
force-pushed
the
aarch64-support-separate-common-os-logic
branch
from
392c1c0 to
a691acb
Compare
Closed
toor1245
pushed a commit
to toor1245/cpu_features
that referenced
this pull request
Jan 22, 2023
To add Windows Arm64 support was added detection of features via Windows API function IsProcessorFeaturePresent. Added _M_ARM64 to detect CPU_FEATURES_AARCH64 macro on Windows. Added initial code for Windows Arm64 testing and provided test for Raspberry PI 4. We can't use "define_introspection_and_hwcaps.inl" as a common file for all operating systems due to msvc compiler error C2099: initializer is not a constant, so as a workaround for Windows I used separate "define_introspection.inl" See also: google#268, google#284, google#186
toor1245
pushed a commit
to toor1245/cpu_features
that referenced
this pull request
Jan 22, 2023
To add Windows Arm64 support was added detection of features via Windows API function IsProcessorFeaturePresent. Added _M_ARM64 to detect CPU_FEATURES_AARCH64 macro on Windows. Added initial code for Windows Arm64 testing and provided test for Raspberry PI 4. We can't use "define_introspection_and_hwcaps.inl" as a common file for all operating systems due to msvc compiler error C2099: initializer is not a constant, so as a workaround for Windows I used separate "define_introspection.inl" See also: google#268, google#284, google#186
gchatelet
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Add Windows Arm64 support To add Windows Arm64 support was added detection of features via Windows API function IsProcessorFeaturePresent. Added _M_ARM64 to detect CPU_FEATURES_AARCH64 macro on Windows. Added initial code for Windows Arm64 testing and provided test for Raspberry PI 4. We can't use "define_introspection_and_hwcaps.inl" as a common file for all operating systems due to msvc compiler error C2099: initializer is not a constant, so as a workaround for Windows I used separate "define_introspection.inl" See also: #268, #284, #186 * [CMake] Add windows_utils.h to PROCESSOR_IS_AARCH64 * Add detection of armv8.1 atomic instructions * Update note on win-arm64 implementation and move to cpuinfo_aarch64.h * Remove redundant #ifdef CPU_FEATURES_OS_WINDOWS * Add note on FP/SIMD and Cryptographic Extension for win-arm64 * Add comments to Aarch64Info fields Added comments to specify that implementer, part and variant we set 0 for Windows, since Win API does not provide a way to get information. For revision added comment that we use GetNativeSystemInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement support aarch64 for Windows, macOS and FreeBSD I moved common logic to
src/impl_aarch64__base_implementation.inlwhich is consistency to x86 base impl