Add cache level limits to AddCacheInfo

[wamuir]

list_cpu_features segfaults in at least some cases after 641e24e. I am experiencing on Linux (Comet Lake) and FreeBSD (Kaby Lake). PR resolves by limiting parsing in AddCacheInfo to the range of possible cache levels.

[gchatelet]

Thx for the PR, I spotted it this morning as well.
Can you simply change the for loop as follows (it will prevent unpleasant merging on my side)

  for (int cache_id = 0; cache_id < CPU_FEATURES_MAX_CACHE_LEVEL &&
                         info->size < CPU_FEATURES_MAX_CACHE_LEVEL;
       cache_id++) {

It's still not a proper fix but at least it will fix the corruption.

[gchatelet]

Ha my bad I misread your patch.
The problem is not in list_cpu_features.c but in cpuinfo_x86.c.

I'll send a fix ASAP

[wamuir]

Awesome, thanks!

[gchatelet]

The memory corruption is fixed but cache info might be duplicated (read from Leaf2 and Leaf 4/0x8000001D).
I'll prepare a proper fix ASAP.