Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSE detection on non-AVX CPUs #135

Merged
merged 13 commits into from
Oct 9, 2020
Merged

Fix SSE detection on non-AVX CPUs #135

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
54cba6c
Fix SSE detection on non-AVX CPUs
gchatelet Oct 8, 2020
39f87b7
Fixes typo
gchatelet Oct 8, 2020
daf4dd5
Mock OSX sysctlbyname in tests
gchatelet Oct 9, 2020
eea45d9
Also update other tests
gchatelet Oct 9, 2020
c1363c3
FakeCpu is reset between each tests
gchatelet Oct 9, 2020
8578efa
Fix conflicting name on Windows
gchatelet Oct 9, 2020
a889e27
Disable pre AVX cpu sse detection tests on Windows
gchatelet Oct 9, 2020
e275bac
Guard OS specific code with macros
gchatelet Oct 9, 2020
a1c8001
Fix missing import for tests
gchatelet Oct 9, 2020
b2bb02f
Fix wrong function prototype
gchatelet Oct 9, 2020
5e5145f
Fix wrong mocking of P3 on Windows
gchatelet Oct 9, 2020
9ed5371
Completely guard OS specific parts in x86 tests
gchatelet Oct 9, 2020
6a671e5
Store DWORD instead unsigned long for x86 tests
gchatelet Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Store DWORD instead unsigned long for x86 tests
  • Loading branch information
@gchatelet
gchatelet committed Oct 9, 2020
commit 6a671e593ba5c394c4563c52ab3284ab618d91ff
2 changes: 1 addition & 1 deletion test/cpuinfo_x86_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class FakeCpu {
std::set<std::string> darwin_sysctlbyname_;
#endif // CPU_FEATURES_OS_DARWIN
#if defined(CPU_FEATURES_OS_WINDOWS)
std::set<unsigned long> windows_isprocessorfeaturepresent_;
std::set<DWORD> windows_isprocessorfeaturepresent_;
#endif // CPU_FEATURES_OS_WINDOWS
uint32_t xcr0_eax_;
};
Expand Down