Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared build #113

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Fix shared build #113

merged 3 commits into from
Mar 11, 2020

Conversation

gadoofou87-zz
Copy link

Fixes #108

@Mizux Mizux self-requested a review March 11, 2020 15:11
@Mizux Mizux added the cmake CMake related issue label Mar 11, 2020
CMakeLists.txt Show resolved Hide resolved
@Mizux
Copy link
Collaborator

Mizux commented Mar 11, 2020

also related to #108 we should add CMP0077

At the beginning of the file:

# option() honors normal variables.
# see: https://cmake.org/cmake/help/latest/policy/CMP0077.html
if(POLICY CMP0077)
  cmake_policy(SET CMP0077 NEW)
endif()

thus passing -DBUILD_PIC=ON won't be overwritten by CMake...

@Mizux Mizux requested review from Mizux and removed request for Mizux March 11, 2020 16:33
@Mizux Mizux self-assigned this Mar 11, 2020
@Mizux Mizux added bug Something isn't working enhancement New feature or request labels Mar 11, 2020
@Mizux Mizux merged commit eb168a2 into google:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake CMake related issue enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared build not working?
2 participants