use full-qualified label for jcommander BUILD file#201
Closed
xytan0056 wants to merge 1 commit intogoogle:masterfrom
Closed
use full-qualified label for jcommander BUILD file#201xytan0056 wants to merge 1 commit intogoogle:masterfrom
xytan0056 wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
xytan0056
referenced
this pull request
Jul 21, 2022
Change-Id: Ieec78532d354a274428e3a6861d65435fc9616eb
xytan0056
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently when running
copybara_maven_repositories()in an external workspace, bazel cannot accessjcommander.BUILDfile, because the directoryexternal/third_partyis not marked as a package. This PR fixes this by addingBUILDfile under the said directory and use ful-qualified label.