Add finalizer for x509_Revoked #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
sbgoog
reviewed
Jun 23, 2025
| protected void finalize() throws Throwable { | ||
| try { | ||
| if (mContext != 0) { | ||
| NativeCrypto.X509_REVOKED_free(mContext); |
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
sbgoog
reviewed
Jun 23, 2025
| import java.io.ByteArrayOutputStream; | ||
| import java.lang.AutoCloseable; |
There was a problem hiding this comment.
No need to import java.lang classes.
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
Bug: 383304212 Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443
sbgoog
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 383304212
Change-Id: Ia9b7418c50e2d415f3147af2a2cc2a0a46c67443