Skip to content

Fix duplicate Day 2 Afternoon exercise page #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgeisler
Copy link
Collaborator

Spotted by @gregpaton08 in #913.

@mgeisler mgeisler requested review from djmitche and qwandor August 28, 2023 12:06
mgeisler referenced this pull request Aug 28, 2023
- Morning of Day 1 still introduces the language and its high-level
goals/value proposition, and starts with the built-in data types Rust
provides, and how you define a function. 
- Afternoon of Day 1 gets a front loading of the basic control flow
structures in Rust but not the more exotic ones.
- The exercises for day 1 afternoon will be the Luhn algorithm (where we
can match on digits and enums such as `Option`.
- Morning of day 2 still has discussion of memory management.

Fixes #510.

---------

Co-authored-by: Martin Geisler <mgeisler@google.com>
@mgeisler
Copy link
Collaborator Author

This was found here: d3a9037#r125548839.

@mgeisler
Copy link
Collaborator Author

@fw-immunant, we'll probably merge the before you get online, but please skim it too to ensure I haven't forgotten anything.

@mgeisler
Copy link
Collaborator Author

Hmm, this isn't completely right:

Day 2: Morning Exercises

We will look at implementing methods in two contexts:

  • Simple struct which tracks health statistics.
  • Multiple structs and enums for a drawing library.

The exercise named "A Simple GUI Library" is on Day 3 Morning.

Copy link
Collaborator

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this.

Edit: Ah, I see. Let me take a closer look and figure out what exactly should be where.

@mgeisler
Copy link
Collaborator Author

Edit: Ah, I see. Let me take a closer look and figure out what exactly should be where.

Thanks a lot! I started looking, but got a bit lost myself 😄

@fw-immunant
Copy link
Collaborator

I think the "Iterators and ownership" exercise actually works better in the afternoon before the other exercise with iterators, because it's more informative than exploratory, and the other exercise from afternoon of day 2 also works with iterators. Meanwhile, the book library and health statistics exercises are mostly simple logic written as methods, with a bit of interaction with ownership and borrowing, which match the morning curriculum.

Let me push an alternative PR.

@djmitche
Copy link
Collaborator

FWIW there's already a subsequent reorg of this content planned, so I don't think it's worth spending too much time on this. Let's get it to a spot where it can be taught, and then focus on the v2.

@mgeisler
Copy link
Collaborator Author

Thanks for putting up #1136.

FWIW there's already a subsequent reorg of this content planned, so I don't think it's worth spending too much time on this. Let's get it to a spot where it can be taught, and then focus on the v2.

Agreed. We'll close this and merge #1136 to get the loop fixed.

@mgeisler mgeisler closed this Aug 28, 2023
fw-immunant added a commit that referenced this pull request Aug 28, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this pull request Sep 12, 2023
@mgeisler mgeisler deleted the fix-duplicate-exercise-page branch December 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants