This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Made Uuid a class #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Uuid was an interface, but every implementation was the same. Every time someone made implemented Uuid, they would have to call Uuids.complete on it to fill in the missing functions. Making Uuid a class solves all these problems as all the methods will be implemented correctly and there only needs to be one implementation. Generators are still sepearate.
crepricg
approved these changes
Apr 3, 2017
| // GENERATOR | ||
| // | ||
| // This interface defines the inteface used for any class that will | ||
| // create Uuids. It is nested in here as for naming reasons. The two |
| // | ||
| // This interface defines the inteface used for any class that will | ||
| // create Uuids. It is nested in here as for naming reasons. The two | ||
| // options was to have it sit along side Uuid can be called UuidGenerator |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Uuid was an interface, but every implementation was the same. Every time someone made implemented Uuid, they would have to call Uuids.complete on it to fill in the missing functions.
Making Uuid a class solves all these problems as all the methods will be implemented correctly and there only needs to be one implementation.
Generators are still separate.