-
Notifications
You must be signed in to change notification settings - Fork 588
[Fix] Correctly set testcase build url and gn args for fuzzing on batch #5013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| def test_set(self): | ||
| """Test set everything.""" | ||
| def test_testcase_metadata_from_env(self): | ||
| """Tests the initial testcase metadata set from the env vars.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide any evidence this changes will not break anything in prod?
I added to the PR description. PTAL |
Fix missing testcase metadata when fuzz task is running on batch (or any non-local execution).
Context
Some build-related environment variables (
build_url,build_keyandgn_args_path) are set during the build setup on fuzz task main stage. These should be retrieved during postprocess to set the testcase's metadata, which is used to display the build url and the gn args config section on the clusterfuzz UI.However, for non-local execution, these variables are not propagated through the
uworker_outputproto and are missing in postprocess, so any testcase created during fuzzing on batch is not displaying these values.Changes
build_url,build_keyandgn_argsfields to the fuzz task output message.Tests
Testing on development environment is ineffective as it is not currently running fuzz tasks on batch. I deployed to dev anyway and confirmed that, at least, the local execution of fuzz tasks is still working.
Testing on prod (deployed this PR to internal)
Evidence of testcases creates after the deploy containing the build url and GN config args:
Bug: b/441128474
Related issue: #4914