Skip to content

[Tracing] Add testcase fixed and rejection events to progression task #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

ViniciustCosta
Copy link
Collaborator

@ViniciustCosta ViniciustCosta commented Jul 21, 2025

This PR instruments the progression task code in order to emit events for testcases being fixed (TestcaseFixedEvent) or rejected (TestcaseRejectionEvent).

AFAICT there are basically 4 codepaths that change the testcase state to either fixed or invalid (i.e., where the testcase.fixed and testcase.open metadata are updated):

  • When it finds the fixed revision range: Emit TestcaseFixedEvent with fixed revision range.
  • When it is fixed in the latest custom build (only for custom binary jobs): Emit TestcaseFixedEvent with latest custom build revision.
  • When it reaches a bad state of min and max revisions (min >= max): Emit TestcaseRejectionEvent with progression bad state.
  • When an expected build no longer exists: Emit TestcaseRejectionEvent with progression build not found.

Testing

  • Added unit tests to verify the correct event emit during progression task.
  • Testing in runtime will be done by deploying to our development environment.

b/394055138

@ViniciustCosta
Copy link
Collaborator Author

Evidence of this working on development environment:
image

@ViniciustCosta ViniciustCosta merged commit 0487d6c into master Jul 24, 2025
7 checks passed
@ViniciustCosta ViniciustCosta deleted the feat/instrument_testcase_fixed_events branch July 24, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants