Skip to content

Fix login exception. #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix login exception. #1979

merged 1 commit into from
Aug 18, 2020

Conversation

@oliverchang
Copy link
Collaborator

@oliverchang oliverchang commented Aug 18, 2020

No description provided.

@google-cla google-cla bot added the cla: yes CLA signed. label Aug 18, 2020
@oliverchang
Copy link
Collaborator Author

oliverchang commented Aug 18, 2020

/gcbrun

@oliverchang
Copy link
Collaborator Author

oliverchang commented Aug 18, 2020

TBR for simple fix.

@oliverchang oliverchang merged commit 7584db9 into master Aug 18, 2020
inferno-chromium
inferno-chromium reviewed Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Dor1s
Dor1s reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliverchang oliverchang deleted the login-exception branch January 21, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inferno-chromium inferno-chromium inferno-chromium left review comments

+1 more reviewer

@Dor1s Dor1s Dor1s left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes CLA signed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverchang @Dor1s @inferno-chromium