Fix WebAssembly externs #3913
Merged
Fix WebAssembly externs #3913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAssembly.RuntimeError takes three optional params: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/RuntimeError/RuntimeError WebAssembly.instantiateStreaming can take a response as well as promise of one: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming#parameters
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Feb 4, 2022
There are a couple of places where I think closure has bad/lacking extern definitions upstream. See: google/closure-compiler#3913 Otherwise this is moslut simply a questions of adding the needed type annotation. Hopefully now that I've addd a test for INCLUDE_FULL_LIBRARY we won't see regressions going forward. A few places there were actual unused arguments being passed. Fixes: #12728
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Feb 4, 2022
There are a couple of places where I think closure has bad/lacking extern definitions upstream. See: google/closure-compiler#3913 Otherwise this is moslut simply a questions of adding the needed type annotation. Hopefully now that I've addd a test for INCLUDE_FULL_LIBRARY we won't see regressions going forward. A few places there were actual unused arguments being passed. Fixes: #12728
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Feb 4, 2022
There are a couple of places where I think closure has bad/lacking extern definitions upstream. See: google/closure-compiler#3913 Otherwise this is moslut simply a questions of adding the needed type annotation. Hopefully now that I've addd a test for INCLUDE_FULL_LIBRARY we won't see regressions going forward. A few places there were actual unused arguments being passed. Fixes: #12728
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Feb 4, 2022
There are a couple of places where I think closure has bad/lacking extern definitions upstream. See: google/closure-compiler#3913 Otherwise this is moslut simply a questions of adding the needed type annotation. Hopefully now that I've addd a test for INCLUDE_FULL_LIBRARY we won't see regressions going forward. A few places there were actual unused arguments being passed. Fixes: #12728
rishipal
approved these changes
Mar 31, 2022
|
I submitted this with 8efa9de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly.RuntimeError takes three optional params:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/RuntimeError/RuntimeError
WebAssembly.instantiateStreaming can take a response as well as promise
of one:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming#parameters