Scripts without either import or export are dropped from compilation

[ChadKillingsworth]

The new ES6 module force rewriting is no longer adding goog.provide calls and dependency information - the script is thus dropped.

[ChadKillingsworth]

Since we have tests for this case, I'm trying to figure out why it still drops the file.

[blickly]

Is it the --language_in=ES6? I found it a bit confusing that commonjs code that doesn't use any other ES6 features can also be depending on ES6 transpilation.

[ChadKillingsworth]

Yes. I figured out what's happening. Dependency pruning is occurring before the goog.provide statement is added. The tests fail if the dependency mode is changed to STRICT.

[blickly]

Ah, whoops. Sorry about that!

[blickly]

Looks like the current github tree is a little behind wrt a recent change I made to this code. Let me take over this bug.

[ChadKillingsworth]

ES6 modules that have import statements but no export statements aren't getting goog.provide calls added either.

[ChadKillingsworth]

This line is the culprit: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/Es6RewriteModules.java#L473

An ES6 module which imports but doesn't export still needs a goog.provide statement - otherwise ProcessClosurePrimitives emits a "missing provide" error.

It would be nice if we could somehow mark those provides as synthetic so that ProcessClosurePrimitives didn't actually emit the namespace initialization statement.

[ChadKillingsworth]

This project makes a great test case: https://github.com/azakus/closure-reorder-import