Boolean operations on non-boolean literals should cause compiler warnings

[ajpaon]

I accidentally wrote a bit of code that looks like this:

var myString = 'string1' || 'string2';

This ought to be caught at compile time, as myString will never have a value of 'string2'.

[blickly]

As long as the first string's value isn't '', that is.

[ajpaon]

Good point - but then the variable will always be set to the second string. Either way there's dead code that the compiler can call attention to.

[Dominator008]

@ajpaon The compiler already optimizes this. Using SIMPLE_OPTIMIZATIONS:

var myString = 'string1' || 'string2';

becomes

var myString="string1";

and

var myString = '' || 'string2';

becomes

var myString="string2";

It might be nice to have a lint check for this though.