Skip to content

Commit

Permalink
Update some comments referring to the now-deleted J2CL build of JSCom…
Browse files Browse the repository at this point in the history
…piler

PiperOrigin-RevId: 708046871
  • Loading branch information
lauraharker committed Dec 20, 2024
1 parent bf416ea commit f969c32
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
12 changes: 6 additions & 6 deletions src/com/google/javascript/jscomp/base/format/SimpleFormat.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
import org.jspecify.annotations.Nullable;

/**
* This is a hacked apart version of the Apache Harmony String.format class
* with all parts outside of the GWT subset removed. It will work for
* simple format commands but does not handle I18N and doesn't handle complex
* formatting options such as calendar entries and hashcodes.
* This is a hacked apart version of the Apache Harmony String.format class with all parts outside
* of the GWT subset removed. It will work for simple format commands but does not handle I18N and
* doesn't handle complex formatting options such as calendar entries and hashcodes.
*
* Formats arguments according to a format string (like {@code printf} in C).
* <p>
* <p>Formats arguments according to a format string (like {@code printf} in C).
*
* <p>TODO: b/384760309 - replace with standard String.format
*/
public final class SimpleFormat {
final StringBuilder out;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ public static Builder builder() {
// Use reference equality to prevent bad HashSet<ModuleMetadata> performance on GWT.
// GatherModuleMetadata is guaranteed to create exactly one ModuleMetadata instance for each
// input module.
// NOTE(user): consider removing this override now that GWT & J2CL builds are gone.
@Override
public final boolean equals(Object other) {
return super.equals(other);
Expand Down
2 changes: 0 additions & 2 deletions src/com/google/javascript/rhino/JSIdentifier.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@
/**
* Utility class to hold isJSIdentifier.
*
* <p>Separated into its own class because it is not GWT compatible.
*
* <p>IMPORTANT: As of 2018-03-09 it is still not possible to use Java 8 features in this file due
* to limitations on some internal Google projects that depend on it.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import java.io.ByteArrayOutputStream;
import java.util.List;

/** CompilerTestCase utilities that can be super sourced out for GWT/J2CL implementation. */
/** CompilerTestCase utilities */
public final class CompilerTestCaseUtils {
public static Compiler multistageSerializeAndDeserialize(
CompilerTestCase testCase,
Expand Down

0 comments on commit f969c32

Please sign in to comment.