-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #778
Refactoring #778
Conversation
@grant Here is a proposal for new foundations in order to refactor Currently the code base has very mixed coding styles, numerous kludgy hacks as well as some architecture problems (uncatched exceptions especially on Windows, sync/async context leaking, etc.) I can work in order to improve this, with your ascent. |
I would use a Google tool since this is a Google project. See my comment. Ping me after the change |
I really don't work on this library anymore. There is no point in using lerna, it's not worth it. Feel free to try it if you want. |
Which bring us back to the issue of this project governance sadly :( |
Thats such a shame. |
@grant This PR now only uses Changes are mostly about the code (error management, floating promises, etc.) and not about features (nothing new, maybe some stability issues fixed) Do you know why the latest commit did not trigger Travis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Not sure about Travis |
Please change title |
CI Requests are issued... and succeed... but they are delayed/queued. So it is likely just a cosmetic thing. |
@grant can you ask for a release? Still no one to take your place yet, right? |
Sorry, I can't release. Only G Suite folks. |
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
npm run test
succeeds.npm run lint
succeeds.