-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 engine support #739
V8 engine support #739
Conversation
@shinout : please review & test this PR if OK, we'll ask grant for a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your changes seem good to me 👍
One thing I would like to request is that the getTranspileOptions()
in files.ts
should use ts.findConfigFile()
. Otherwise, tsconfig files cannot be found in monorepo-structured projects.
function getTranspileOptions(): ts.TranspileOptions {
const projectPath = findUp.sync(DOT.PROJECT.PATH);
const tsconfigPath = projectPath
? ts.findConfigFile(projectPath, ts.sys.fileExists)
: undefined;
if (!tsconfigPath) {
return {};
}
const tsconfigContent = fs.readFileSync(tsconfigPath, FS_OPTIONS);
const parsedConfigResult = ts.parseConfigFileTextToJson(
tsconfigPath,
tsconfigContent
);
return {
compilerOptions: parsedConfigResult.config.compilerOptions
};
}
This may work.
@PopGoesTheWza |
@shinout I am unsure what you mean. I had no time for testing clasp push of ES2019 yet but intend to do so this weekend. |
@PopGoesTheWza
The essence is that the main directory (gas-package01 here) is two or more directories distant from tsconfig.json. The current implementation only considers the parent directory of a given project.
Sorry about that. Let me explain more precisely. The command |
@grant ready for release. I drafted the release notes https://github.com/google/clasp/releases/edit/untagged-477cea24e1e150fb3fc4 |
Fixes #735
npm run test
succeeds.npm run lint
succeeds.