Delete uses of DefaultSignerFactory #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
approved these changes
Jul 27, 2017
trillian/ctfe/instance_test.go
Outdated
|
|
||
| for _, test := range tests { | ||
| _, err := SetUpInstance(ctx, nil, &test.cfg, sf, time.Second, monitoring.InertMetricFactory{}) | ||
| _, err := SetUpInstance(ctx, nil, &test.cfg, time.Second, monitoring.InertMetricFactory{}) |
Contributor
There was a problem hiding this comment.
nit: Scope err on the if?
RJPercival
force-pushed
the
signerfactory_del
branch
2 times, most recently
from
32a24fa to
d50c8d7
Compare
Key protobuf to crypto.Signer conversion is now handled by a global registry of handler funcs.
RJPercival
force-pushed
the
signerfactory_del
branch
from
d50c8d7 to
878ad4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR google/trillian#734 deletes DefaultSignerFactory and moves/renames some crypto funcs. This PR makes the required changes to accommodate this.