Mark arena as nullable
#1678
Merged
Mark arena as nullable
#1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_801935442
branch
from
f45dbee to
4060eb2
Compare
`CustomListValue::CustomListValue()` set's it into nullptr and it triggers `-fsanitize=nullability`. There are not deference of this pointer, it used only in comparison. Marking it `nonnull` does not help to protect dereferences. Also mark `arena` as const, to make sure it's not used for allocation, those methods are non-const. PiperOrigin-RevId: 802145149
copybara-service
bot
force-pushed
the
test_801935442
branch
from
4060eb2 to
43892bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
arenaas nullableCustomListValue::CustomListValue()set's it into nullptr and it triggers-fsanitize=nullability.There are not deference of this pointer, it used only in comparison. Marking it
nonnulldoes not help to protect dereferences.Also mark
arenaas const, to make sure it's not used for allocation, thosemethods are non-const.