This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Merged
Conversation
When searching use the filtered samples instead of the full list fix #35
When using viewBinding as a field in a class KSP cannot resolve the type and make the validation fail, skipping the class. We don't need to check the class fields, so let's just skip it. Note: There might be a better way to do that
yaraki
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip class field validation to fix viewBinding issue
When using viewBinding as a field in a class KSP cannot resolve the type
and make the validation fail, skipping the class.
We don't need to check the class fields, so let's just skip it.
Note: There might be a better way to do that