This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Merged
Conversation
To enable possible use-cases to search for samples in the binary or perform some sort of reflection at runtime we are changing the retention to RUNTIME.
yrezgui
previously requested changes
Mar 1, 2023
yrezgui
left a comment
yrezgui
left a comment
There was a problem hiding this comment.
Should you update the ProGuard file to make sure we're not losing information when compressing the output?
Contributor
Author
Since this is purely for debug use-cases there is no need to keep them when proguarded. |
yaraki
approved these changes
Mar 2, 2023
marcelpinto
dismissed
yrezgui’s stale review
As mentioned, for the use case it's okay if proguard strips it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable possible use-cases to search for samples in the binary or perform some sort of reflection at runtime we are changing the retention to RUNTIME.