This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Improve the edge-to-edge implementation#13
Merged
marcelpinto merged 3 commits intomainfrom Jan 11, 2023
Merged
Conversation
The status bar is transparent and shows the app bar behind. The actionbar is hidden in the theme rather than in the code so that Scaffold can reflect the correct inset values LazyColumn uses the padding values at the content end rather than the list itself.
Contributor
Author
|
The status bar shows the app bar behind. The list stretches till the screen end.
|
marcelpinto
suggested changes
Jan 9, 2023
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| // Ensure that the declaring activity theme don't show an actionbar | ||
| actionBar?.hide() |
Contributor
There was a problem hiding this comment.
I think we should keep this? Given that the client could potentially use any theme since it's extending the activity. This ensures the actionBar would be hidden and avoid the double toolbar
Contributor
Author
There was a problem hiding this comment.
We can keep this, but we still need to hide the action bar in the theme. Otherwise, Scaffold cannot find the correct inset values.
marcelpinto
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status bar is transparent and shows the app bar behind.
The actionbar is hidden in the theme rather than in the code so that Scaffold can reflect the correct inset values
LazyColumn uses the padding values at the content end rather than the list itself.
Please add a descriptive PR title