Caliper on Java 6 VM and ClassNotFound when using class defined on classpath.#317
Open
phishman3579 wants to merge 7 commits intogoogle:masterfrom
Open
Caliper on Java 6 VM and ClassNotFound when using class defined on classpath.#317phishman3579 wants to merge 7 commits intogoogle:masterfrom
phishman3579 wants to merge 7 commits intogoogle:masterfrom
Conversation
added 4 commits
August 11, 2015 16:36
…oopbackAddress() error', '14 objects and 1960 bytes are the known values', and 'Out of Memory'. Tests including AllocationInstrumentTest, BadUserCodeTest
…ined in the classpath
added 3 commits
August 13, 2015 13:00
…ested and seems to be failing on CI tests
abimarank
reviewed
Jun 14, 2023
| try { | ||
| urls = new URL[] { ROOT.toURI().toURL() }; | ||
| } catch (MalformedURLException e) { | ||
| System.err.println("Could get root URI, class lookup via Util.lookupClass() will not work. root="+ROOT); |
There was a problem hiding this comment.
Do we really need to log with System.io?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a number of issues when using Caliper with a Java 6 VM (1.6.0_65):
Fixed ClassNotFound exception when trying to load a class which was defined in a jar on the classpath (this is a java 6 & 7 problem, I believe):