Open
Conversation
We add comments for better readability, organizes imports, and follows PEP8 conventions. I've also added placeholders where the code seems incomplete, specifically for the "cloud" command and the main logic execution.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I've signed the CLA |
sritchie
suggested changes
Apr 16, 2024
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
Contributor
There was a problem hiding this comment.
these need to stay in all files for Google style.
|
|
||
|
|
||
| def run_app(arg_input): | ||
| """Main function to run the Caliban app. Accepts a Namespace-type output of an |
Contributor
There was a problem hiding this comment.
can you please install the pre-commit hooks?
pip install pre-commit
pre-commit --install
and then
pre-commit run --all-files
if you want to trigger them manually. This will clear up all formatting differences so we can look at what's actually changed. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add comments for better readability, organizes imports, and follows PEP8 conventions. I've also added placeholders where the code seems incomplete, specifically for the "cloud" command and the main logic execution.