Fix network info for docker containers running with --net=host. #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmarmol This fixes empty network display for kube containers. |
| spec.HasNetwork = len(config.Networks) > 0 | ||
| // Docker reports a loop device for containers with --net=host. Ignore | ||
| // those too. | ||
| spec.HasNetwork = len(config.Networks) > 1 |
There was a problem hiding this comment.
WDYT if we count the non-loopback devices? If in the future this changes we don't have to worry about it.
There was a problem hiding this comment.
Sure, changed to counting non-loopback devices.
Docker still reports a loop device for these. Need to check for more than one device to mark network as available.
|
LGTM, thanks @rjnagal! |
vmarmol
added a commit
that referenced
this pull request
Aug 24, 2015
Fix network info for docker containers running with --net=host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker still reports a loop device for these. Need to check for
more than one device to mark network as available.