Change logic for determining minimum polling frequency. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since polling is tied to housekeeping, minimum supported polling frequency is 1s. Users can specify polling frequency higher than 1s. The polling loop will be called at the minimum frequency specified in config as long as its higher than the minimum supported frequency.
|
@anushree-n I think this is the model we want to go with. WDYT? |
| @@ -85,6 +82,12 @@ func NewCollector(collectorName string, configfile string) (*GenericCollector, e | |||
| } | |||
| } | |||
|
|
|||
| // Minimum supported polling frequency is 1s. | |||
| minSupportedFrequency := 1 * time.Second | |||
There was a problem hiding this comment.
In theory it should be the value of minHousekeeping flag :)
There was a problem hiding this comment.
yes, but importing HousekeepingInterval adds a cyclic dependency between manager and collector. I'll clean that up next.
|
I believe the earlier model took the minimum of next stats collection and next custom metrics collection as the next housekeeping time. If the minimum supported frequency is 1s, yes, this looks good! :) |
|
yeah, the intention is to not go below the housekeeping interval. |
|
self-merging .... |
rjnagal
added a commit
that referenced
this pull request
Jul 20, 2015
Change logic for determining minimum polling frequency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since polling is tied to housekeeping, minimum supported polling
frequency is 1s.
Users can specify polling frequency higher than 1s. The polling loop
will be called at the minimum frequency specified in config as long as
its higher than the minimum supported frequency.