Add --docker_only flag to enable tracking for only docker containers & root. #670
+95
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjnagal
changed the title
| Name: containerName, | ||
| } | ||
|
|
||
| // Check that the container didn't already exist. |
rjnagal
force-pushed
the
docker
branch
2 times, most recently
from
a95dd2b to
81f4279
Compare
|
We'll print out each new raw container as a failure. We will also "detect" them every 60s and re-print out the failure. We need to somehow tell the manager to ignore the container. Maybe create it but don't house keep it? |
…and root. This reduces unnecessary load on the system and also cleans up the UI clutter. Currently defaulted to false.
|
Just ignoring housekeeping still shows the container in all APIs and UI. Its a query-able container that doesn't return anything. Uploaded a different fix that distinguish failed vs ignored containers in manager and silently fails the latter. PTAL. |
|
LGTM, thanks @rjnagal! Merging, the e2e machines are unhappy :( |
vmarmol
added a commit
that referenced
this pull request
May 1, 2015
Add --docker_only flag to enable tracking for only docker containers & root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces unnecessary load on the system and also cleans up the UI clutter.
Currently defaulted to false.