Added a basic api interface for events #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
kateknister
force-pushed
the
apiBranch
branch
3 times, most recently
from
8048468 to
f882636
Compare
|
I'm putting in the streaming write function next, but I tried to break it up a bit by not putting it in this commit. |
|
ok to test |
| @@ -50,7 +52,9 @@ func getApiVersions() []ApiVersion { | |||
| v1_1 := newVersion1_1(v1_0) | |||
| v1_2 := newVersion1_2(v1_1) | |||
| v2_0 := newVersion2_0(v1_2) | |||
There was a problem hiding this comment.
nit: make v2_0 depend on v1_3
|
Looks good overall :) only minor comments. |
kateknister
force-pushed
the
apiBranch
branch
from
f882636 to
e25510b
Compare
| } | ||
|
|
||
| for key, val := range urlMap { | ||
| if key == "all_time" { |
There was a problem hiding this comment.
What about we check each of these instead of checking in a loop:
if val, ok := urlMap["all_time"]; ok {
getEventsFromAllTime = strconv.ParseBool(val[0])
}
|
Tests look good :) |
kateknister
force-pushed
the
apiBranch
branch
2 times, most recently
from
0b67650 to
0dfa447
Compare
| assert.Nil(t, err) | ||
| } | ||
|
|
||
| func TestGetEventEmptyStringRequest(t *testing.T) { |
There was a problem hiding this comment.
We can probably remove this test, dupe of the above.
kateknister
force-pushed
the
apiBranch
branch
from
0dfa447 to
0744ed1
Compare
|
I removed the extra test |
| } | ||
| if err != nil { | ||
| glog.Warning("Failed to process watch event: %v", err) | ||
| if err != nil { |
There was a problem hiding this comment.
Looks like this should be moved outside the switch.
kateknister
force-pushed
the
apiBranch
branch
from
0744ed1 to
6e14267
Compare
|
LGTM |
kateknister
added a commit
that referenced
this pull request
Feb 26, 2015
Added a basic api interface for events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.