Added a way for oom events to be handled by the manager #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateknister
force-pushed
the
apiBranch
branch
from
74d1e5b to
39198c4
Compare
|
Can one of the admins verify this patch? |
|
Looks like it needs a rebase :)
|
|
ok to test
|
|
Does it still need a rebase? |
|
|
||
| // can be called by the api which will take events returned on the channel | ||
| func (self *manager) WatchForEvents(request *events.Request, passedChannel chan *events.Event) error { | ||
| err := self.eventHandler.WatchEvents(passedChannel, request) |
There was a problem hiding this comment.
We can just return the result here
|
Yep, shows one commit now :) |
kateknister
force-pushed
the
apiBranch
branch
from
39198c4 to
5f66cbc
Compare
|
LGTM |
vmarmol
added a commit
that referenced
this pull request
Feb 21, 2015
Added a way for oom events to be handled by the manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.