Added an oom monitor to manager #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
kateknister
force-pushed
the
apiBranch
branch
from
5d528a4 to
648820e
Compare
| @@ -623,3 +625,28 @@ func (self *manager) watchForNewContainers(quit chan error) error { | |||
| }() | |||
| return nil | |||
| } | |||
|
|
|||
| func (self *manager) watchForNewOoms() error { | |||
| outStream := make(chan *oomparser.OomInstance) | |||
There was a problem hiding this comment.
Lets make this a buffered channel, we can start with 10? See how that goes :)
|
Added some small comments. Let me know when those are addressed :) |
kateknister
force-pushed
the
apiBranch
branch
2 times, most recently
from
cf62dfe to
3a4519d
Compare
| } | ||
| err = oomLog.StreamOoms(outStream) | ||
| if err != nil { | ||
| glog.Errorf("error streaming OOMs: %v", err) |
There was a problem hiding this comment.
here we can return the error
kateknister
force-pushed
the
apiBranch
branch
from
3a4519d to
e542ff0
Compare
|
LGTM |
kateknister
force-pushed
the
apiBranch
branch
from
0f8623a to
3856690
Compare
kateknister
added a commit
that referenced
this pull request
Feb 20, 2015
Added an oom monitor to manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.