Handle old versions of the libcontainer config. #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| d := json.NewDecoder(f) | ||
| retConfig := new(libcontainer.Config) | ||
| err = d.Decode(retConfig) | ||
| var config libcontainer.Config |
There was a problem hiding this comment.
This is ugly. May be put a TODO to remove it a few months from now.
There was a problem hiding this comment.
Yeah...this is like the third such thing we have sadly. Added the TODO.
|
LGTM |
Libcontainer recently changed its config by changing the type of a field. This commit tries parsing the config as the new and old types.
vmarmol
force-pushed
the
old-libcontainer
branch
from
4a504ff to
7ca63db
Compare
vishh
added a commit
that referenced
this pull request
Dec 17, 2014
Handle old versions of the libcontainer config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libcontainer recently changed its config by changing the type of a
field. This commit tries parsing the config as the new and old types.