Drop unused setNetworkStats #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dims
force-pushed
the
drop-unused-setNetworkStats
branch
from
c5ba3f0
to
80497bd
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
drop-unused-setNetworkStats
branch
from
80497bd
to
50fab77
Compare
cwangVT
reviewed
Oct 25, 2024
|
LGTM |
cwangVT
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid referring to the things in the library's root directory:
"github.com/opencontainers/runc/libcontainer"since we never even threaded in support for network stats. We are creatinglibcontainer.Statswith cgroup stats but network stats are empty.https://github.com/google/cadvisor/blame/96c346ed6af33ecc856f82dfd9ef6b0fd6b66949/container/libcontainer/handler.go#L92-L95
PS: This will eventually help us minimize the things we use in runc.