Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid linting in Prow CI jobs #3608

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dims
Copy link
Collaborator

@dims dims commented Oct 18, 2024

Linting is failing in prow CI jobs. We should not be running linters in periodic CI jobs,

By definition in Makefile, all is defined as:

all: presubmit build test

Since linters SHOULD be run in presubmits, let's skip them in https://testgrid.k8s.io/sig-node-cadvisor#cadvisor-e2e by limiting the targets to build test

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims
Copy link
Collaborator Author

dims commented Oct 18, 2024

xref: #3606

@dims
Copy link
Collaborator Author

dims commented Oct 18, 2024

/test pull-cadvisor-e2e

@cwangVT cwangVT merged commit 9764cdc into google:master Oct 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants