Skip to content

Add support for non btrfs devices in GetDirFsDevice #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

Add support for non btrfs devices in GetDirFsDevice #2836

merged 1 commit into from
Mar 26, 2021

Conversation

saschagrunert
Copy link
Contributor

@saschagrunert saschagrunert commented Mar 22, 2021 •
edited
Loading

We can create a *DeviceInfo from the mount even if the FSType is not
btrfs.

Refers to: kubernetes/kubernetes#94825
Testing in: kubernetes/kubernetes#100451

@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@k8s-ci-robot
Copy link
Collaborator

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert added a commit to saschagrunert/kubernetes that referenced this pull request Mar 22, 2021
@saschagrunert
Test cadvisor PR kubernetes#2836
0cb4136 
This test should trigger the CI for
google/cadvisor#2836.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Mar 22, 2021
Closed
@saschagrunert
Copy link
Contributor Author

CI in kubernetes/kubernetes#100451 was green, removing the WIP from here.

@saschagrunert saschagrunert changed the title WIP: Add support for non btrfs devices in GetDirFsDevice Add support for non btrfs devices in GetDirFsDevice Mar 22, 2021
@saschagrunert saschagrunert mentioned this pull request Mar 22, 2021
Closed
@Creatone
Copy link
Contributor

/ok-to-test

iwankgb
iwankgb reviewed Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@iwankgb iwankgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would appreciate if you improved log message a bit.

@saschagrunert
Add support for non btrfs devices in GetDirFsDevice
f0dbef3 
We can create a `*DeviceInfo` from the mount even if the `FSType` is not
`btrfs`.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Contributor Author

LGTM but I would appreciate if you improved log message a bit.

Done, thank you for the hint! 🙏

@iwankgb iwankgb merged commit 42c236e into google:master Mar 26, 2021
@saschagrunert saschagrunert deleted the dir-fs-device branch March 26, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwankgb iwankgb iwankgb approved these changes

Assignees
No one assigned
Labels
cla: yes ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @k8s-ci-robot @Creatone @iwankgb